Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:change-notif-message #823

Merged
merged 12 commits into from
Mar 28, 2023
Merged

fix:change-notif-message #823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bfc17a5
update notif enum
RiXelanya Mar 26, 2023
294363a
vote dan notif service
RiXelanya Mar 26, 2023
f4a595a
fix notif and vote
RiXelanya Mar 27, 2023
fe0633a
Update notification.service.ts
RiXelanya Mar 27, 2023
2825dac
Update vote.service.ts
RiXelanya Mar 27, 2023
27d74c4
Update database.helper.ts
RiXelanya Mar 27, 2023
aa2e76b
format fix
RiXelanya Mar 27, 2023
1f55d36
update vote.service.ts
RiXelanya Mar 27, 2023
2301e3b
fix-notif
Mar 28, 2023
8641ec7
Merge pull request #1 from RiXelanya/Vote
RiXelanya Mar 28, 2023
26aef09
Merge branch 'myriadsocial:main' into main
RiXelanya Mar 28, 2023
e31f0d0
change message
RiXelanya Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/services/notification.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ export class NotificationService {
async sendVoteCount(
referencetype: ReferenceType,
referenceID: string,
upvotes: number,
): Promise<void> {
const destination: string = await (referencetype === ReferenceType.POST
? this.postRepository
Expand All @@ -166,7 +167,7 @@ export class NotificationService {
const notification = new Notification({
type: NotificationType.VOTE_COUNT,
referenceId: referenceID,
message: 'Your post is getting upvotes',
message: upvotes.toString(),
from: MyriadUserID,
});
const title = 'New Upvotes';
Expand Down
2 changes: 1 addition & 1 deletion src/services/vote.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ export class VoteService {
this.metricService.publicMetric(type, referenceId).then(metric => {
if (this.upvoteCounter(metric.upvotes)) {
this.notificationService
.sendVoteCount(type, referenceId)
.sendVoteCount(type, referenceId, metric.upvotes)
.catch((err: Error) => {
throw err;
});
Expand Down