Skip to content

Commit

Permalink
The latest FakeWeb passes this spec (was pending before).
Browse files Browse the repository at this point in the history
  • Loading branch information
myronmarston committed Aug 23, 2010
1 parent f9e0dab commit ed4a662
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 12 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Expand Up @@ -2,6 +2,8 @@

## In Git

* Updated to use and require FakeWeb 1.3.0. It includes a fix for a bug related to multiple values for the
same response header.
* Optimized `VCR.http_stubbing_adapter.stub_requests` a bit.

## 1.1.0 (August 22, 2010)
Expand Down
4 changes: 0 additions & 4 deletions README.md
Expand Up @@ -283,10 +283,6 @@ additional features. You can see the
[benchmarks](http://github.com/myronmarston/vcr/blob/master/benchmarks/http_stubbing_libraries.rb) for
more details.

Note that FakeWeb also currently has a bug that prevents it from properly dealing with multiple values
for the same response header. See [this FakeWeb issue](http://github.com/chrisk/fakeweb/issues/17) for
more info.

You should not need to directly interact with either FakeWeb or WebMock. VCR will take care of disallowing
http connections when no cassette is inserted, and it will clean up all stubs/registrations when a cassette
is ejected. If you ever decide to switch HTTP stubbing libraries, you'll just have to update the VCR config
Expand Down
8 changes: 0 additions & 8 deletions spec/support/http_library_adapters.rb
Expand Up @@ -250,15 +250,7 @@ def test_request_stubbed(method, url, expected)
end

it "correctly handles stubbing multiple values for the same header" do
perform_test = lambda do
get_header('Set-Cookie', make_http_request(:get, 'http://example.com/two_set_cookie_headers')).should =~ ['bar=bazz', 'foo=bar']
end

if subject == VCR::HttpStubbingAdapters::FakeWeb
pending("waiting for my fakeweb fix to be merged into fakeweb and released", &perform_test)
else
perform_test.call
end
end

context 'when we restore our previous check point' do
Expand Down

0 comments on commit ed4a662

Please sign in to comment.