Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve smartSleep: add a "no more commands" message to the gateway #468

Closed
abmantis opened this issue Jun 11, 2016 · 2 comments
Closed

Comments

@abmantis
Copy link

Currently, smartSleep() simply waits a specified amount of time for any command from the gateway.
Instead, after sending the heartbeat, the node could wait (with a timeout value) for a "no more commands" message from the gateway and sleep after receiving that. This would reduce the waiting time before sleeping.
Another improvement would be having a "request commands" from the node instead of the heartbeat.

So, on the node:

  • Send "request commands"
  • Wait until "no more commands" is received
  • Sleep

On the gateway:

  • "request commands" is received from a node
  • Send commands to node
  • Send "no more commands" message.
@tekka007 tekka007 added this to the 3.0.0 milestone Jun 13, 2016
@tekka007 tekka007 mentioned this issue Aug 1, 2016
@MartinHjelmare
Copy link
Contributor

This is good. I assume the gateway in the above description means the controller.

@tekka007
Copy link
Contributor

see #722, use dedicated messages

@fallberg fallberg removed this from the 3.0.0 milestone Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants