Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major RF24 library rework: minimal driver at full specs #392

Merged
merged 2 commits into from
Apr 27, 2016
Merged

Major RF24 library rework: minimal driver at full specs #392

merged 2 commits into from
Apr 27, 2016

Conversation

tekka007
Copy link
Contributor

@tekka007 tekka007 commented Feb 8, 2016

  • strip C++ code
  • 2-fold speed increase
  • reduce code size ~2kb
  • eliminate non-essential register polling/writing
  • use 2 RX pipes

tbowmo
tbowmo reviewed Feb 9, 2016
View reviewed changes
libraries/MySensors/MyConfig.h
// Requires DEBUG to be enabled.
// This will add even more to the size of the final sketch!
//#define MY_DEBUG_VERBOSE

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this removed from MyConfig.h?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be called MY_DEBUG_VERBOSE_RF24 now. A more specific define is fine by me. We should perhaps keep an updated comment in MyConfig so it's easier to find.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding a commented section, like MY_DEBUG_VERBOSE_SIGNING below. Perhaps even add doxygen tags to these so that the debug features gets documented. But that can be made in a separate commit. I encourage everyone to improve on the doxygen parts :)

@tekka007 tekka007 force-pushed the refactoring_RF24 branch 2 times, most recently from 0cf0052 to 6daf3d3 Compare March 6, 2016 20:47
@tekka007 tekka007 force-pushed the refactoring_RF24 branch 6 times, most recently from 77ef71c to ab75bf9 Compare April 24, 2016 07:39
@mysensors-jenkins
Copy link

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

@mysensors-jenkins
Copy link

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

@tekka007 tekka007 merged commit d65e73a into mysensors:development Apr 27, 2016
@tekka007 tekka007 deleted the refactoring_RF24 branch April 27, 2016 21:00
tbowmo pushed a commit to tbowmo/MySensors that referenced this pull request Jul 9, 2016
@tekka007
Merge pull request mysensors#392 from tekka007/refactoring_RF24
a61f5fa 
Major RF24 library rework: minimal driver at full specs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tekka007 @mysensors-jenkins @tbowmo @henrikekblad @fallberg