Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing RF24_NOP refactoring #635

Merged
merged 1 commit into from
Nov 6, 2016
Merged

Conversation

tekka007
Copy link
Contributor

@tekka007 tekka007 commented Nov 6, 2016

@mysensors-jenkins
Copy link

Git commit message(s) look good!

@mysensors-jenkins
Copy link

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

@tekka007 tekka007 merged commit 6ad18b6 into mysensors:development Nov 6, 2016
@tekka007 tekka007 deleted the RF24Fix branch November 6, 2016 09:57
@mfalkvidd
Copy link
Member

great, thanks for fixing @tekka007
would there be a simple way to have Jenkins detect this type of problem in the future?

@tekka007
Copy link
Contributor Author

tekka007 commented Nov 6, 2016

yes, but not implemented yet (afaik, ping @fallberg)

@fallberg
Copy link
Contributor

fallberg commented Nov 9, 2016

What issue is it you want jenkins to detect?
Building linux stuff? That is on the todo list, but I have not been able to raise my workstation from the dead just yet.

@mfalkvidd
Copy link
Member

I just think that detecting that the code won't even compile should be fairly simple (but still requires some work of course)

@fallberg
Copy link
Contributor

Well, anyone is free to submit test sketches to the core repository for this exact purpose. I have done it for signing. So just go ahead if there is a need for something more and perhaps more specific :)

@fallberg
Copy link
Contributor

There is no need to update in the ci server. It will look up things to build, so all you need to do is to provide a sketch in the appropriate folder and jenkins will include it when verifying pull requests.

@tekka007 tekka007 added this to the 2.1.0 milestone Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants