Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing RF24_NOP refactoring #635

Merged
merged 1 commit into from Nov 6, 2016

Conversation

Projects
None yet
4 participants
@mysensors-jenkins

This comment has been minimized.

Copy link

commented Nov 6, 2016

Git commit message(s) look good!

@mysensors-jenkins

This comment has been minimized.

Copy link

commented Nov 6, 2016

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

@tekka007 tekka007 merged commit 6ad18b6 into mysensors:development Nov 6, 2016

3 checks passed

Gitler Git commit message(s) look good!
Details
Jenkins (test sketches) Core tests successful.
Details
clahub All contributors have signed the Contributor License Agreement.
Details

@tekka007 tekka007 deleted the tekka007:RF24Fix branch Nov 6, 2016

@mfalkvidd

This comment has been minimized.

Copy link
Contributor

commented Nov 6, 2016

great, thanks for fixing @tekka007
would there be a simple way to have Jenkins detect this type of problem in the future?

@tekka007

This comment has been minimized.

Copy link
Contributor Author

commented Nov 6, 2016

yes, but not implemented yet (afaik, ping @fallberg)

@fallberg

This comment has been minimized.

Copy link
Contributor

commented Nov 9, 2016

What issue is it you want jenkins to detect?
Building linux stuff? That is on the todo list, but I have not been able to raise my workstation from the dead just yet.

@mfalkvidd

This comment has been minimized.

Copy link
Contributor

commented Nov 9, 2016

I just think that detecting that the code won't even compile should be fairly simple (but still requires some work of course)

@fallberg

This comment has been minimized.

Copy link
Contributor

commented Nov 19, 2016

Well, anyone is free to submit test sketches to the core repository for this exact purpose. I have done it for signing. So just go ahead if there is a need for something more and perhaps more specific :)

@fallberg

This comment has been minimized.

Copy link
Contributor

commented Nov 19, 2016

There is no need to update in the ci server. It will look up things to build, so all you need to do is to provide a sketch in the appropriate folder and jenkins will include it when verifying pull requests.

@tekka007 tekka007 added this to the 2.1.0 milestone Nov 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.