-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#624] Add OutgoingMessage#mail_server_logs #3039
[#624] Add OutgoingMessage#mail_server_logs #3039
Conversation
0582c0e
to
4524744
Compare
Marking as I'm interested in edge cases that make |
Looks good - I wonder if there's going to be some value in storing the association between the outgoing message and the log lines at this point - I think it might be easier to use this code to write some associations to the database and then iterate through them examining them than to try and do all that on the fly. |
Made a note on the original ticket #624 (comment) to do this at a later stage once we've used the on-the-fly way to check a random sample of messages and logs. |
👍 Looks good! |
dbc8c26
to
fccf96a
Compare
Returns the logged Message-IDs of an OutgoingMessage. This will be used to find the MTA ID of the message.
Handle the santisation and creation in a single method call. Can use the new method in specs.
Return the logged MTA IDs for an OutgoingMessage. Currently only implemented for the exim MTA. The specs could be dryed up, and I think there's some more coverage we could add by creating other log lines to ensure the correct ones are plucked from the more complicated list.
Returns the MTA logs for an OutgoingMessage. Only implemented for exim.
fccf96a
to
dab6213
Compare
Part of #624
Basic framework for collecting exim MTA logs for a specific
OutgoingMessage
.Based on my current understanding, the last bits to add to get an
OutgoingMessage#delivered?
value are: