Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5889] Allow Pro admin to always extend embargo #5892

Closed
wants to merge 6 commits into from

Conversation

gbp
Copy link
Member

@gbp gbp commented Sep 15, 2020

Relevant issue(s)

Fixes #5889

What does this do?

  • Refactors ability around when a Pro is allowed to extend an embargo
  • Allow Pro admin to always extend embargo

Why was this needed?

Easier Pro support

This will mean changes will be easier to make with simpler diffs.
Removing from the view will be more reusable and help improve
readability.
View code had this button twice which is unnecessary as we can just
check the if user can "destroy" the embargo and render once.
Removes complexity from the view code.
This skips the embargo expiring soon check for pro admins.
@garethrees garethrees closed this Jun 21, 2022
@garethrees
Copy link
Member

Closed to reduce overwhelm of high WIP. Can reopen in the future if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow pro admins to always extend embargoes
2 participants