[#5815] Truncate search queries that are too long #5914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah it's nice for this kind of thing. I think I first learned of it via 5dcbded |
The maximum length of a search query is 252 bytes. People often paste long strings into the typeahead search which results in an exception being raised. Instead of raising an exception, just truncate the query. We could tell the user the string is too long, but I don't think it's worth it in this case. The typeahead search is pretty opaque to users – it just happens as they enter content – and with a string that long I don't think we'll lose much by truncating it. Fixes #5815.
mysociety-pusher
force-pushed
the
5815-truncate-too-long-typahead-search-query
branch
from
059a3a0
to
0cf2086
Compare
mysociety-pusher
deleted the
5815-truncate-too-long-typahead-search-query
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maximum length of a search query is 252 bytes. People often paste
long strings into the typeahead search which results in an exception
being raised.
Instead of raising an exception, just truncate the query.
We could tell the user the string is too long, but I don't think it's
worth it in this case. The typeahead search is pretty opaque to users –
it just happens as they enter content – and with a string that long I
don't think we'll lose much by truncating it.
Fixes #5815.