Remove dependency on Python #6053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not strictly needed once mysociety/commonlib#71 is merged |
mysociety-pusher
force-pushed
the
remove-python-dependecy
branch
from
210bcb2
to
fe951d1
Compare
|
This would be a step towards #2906 |
garethrees
reviewed
Oct 14, 2021
Instead of using yaml2sh from commonlib this commits adds a new Ruby script at bin/config which can retrieve individual configuration variables from config/general.yml. To get a configuration variable run: bin/config SITE_NAME This bin command doesn't initialise the Rails stack so is fast It also *doesn't* use lib/configuration.rb Ruby module, although it could if some configuration variables had defaults assigned. These are: 1. BUNDLE_PATH 2. SHARED_DIRECTORIES 3. SHARED_FILES 4. SHARED_FILES_PATH 5. STAGING_SITE As I understand it these haven't be given a default because they are only used from the installation shell scripts. Which seems reasonable to me.
gbp
force-pushed
the
remove-python-dependecy
branch
from
fe951d1
to
abc3b60
Compare
garethrees
approved these changes
Oct 29, 2021
|
Have double checked to confirm (through building vagrant boxes for #6615) that the install scripts are still working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using yaml2sh from commonlib this commits adds a new Ruby
script at bin/config which can retrieve individual configuration
variables from config/general.yml.
To get a configuration variable run:
bin/config SITE_NAME
This bin command doesn't initialise the Rails stack so is fast
It also doesn't use lib/configuration.rb Ruby module, although it
could if some configuration variables had defaults assigned. These are:
As I understand it these haven't be given a default because they are
only used from the installation shell scripts. Which seems reasonable to
me.