[#5159] Rails 6 upgrade #6485
Merged
[#5159] Rails 6 upgrade #6485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbp
commented
Sep 7, 2021
garethrees
reviewed
Sep 8, 2021
There was a problem hiding this comment.
0ca6063 – Nice!
What are we doing about the new autoloading stuff? Is that getting handled in #5851 or do they need to be addressed here?
Not much change so fine in principle. I've booted the app successfully but haven't tested further than that.
Rails 5.2 is no more so we can drop the old implementation. Leave conditionals in Gemfiles for when we prep for Rails 6.1.
In development mode Rails might output some deprecation warnings which don't appear in test or production. It seems Rails 6 prepares these warnings ahead of time and they rely on the `#to_sentence` this in turn loads the locales and but because our gettext based strings are loaded in an initializer the available locales aren't yet set. Resulting in a error being raised with our i18n fixes. This change moves all the gettext and locale setup into a Railtie and sets everything up in a `before_configuration` block which runs before any initializers are run. Fixes: ``` ./lib/i18n_fixes.rb:54:in `available_locales': undefined method `map' for nil:NilClass (NoMethodError) ```
This isn't using Zeitwerk yet. We would need load defaults for Rails "6.0" in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #5159
What does this do?
Notes to reviewer
This PR doesn't prep for the Rails 6.1 release as the CI will be red and with how Github actions works we can't allow failures without it putting red crosses everywhere and emailing us. We don't really want that so lets prep in a separate PR and fix CI there.