[#6435] Remove popup banner and JS from request correspondence PDFs #6488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to remove the popup due to WDTK theme using opacity CSS selector for these elements this is causing the wkhtmltopdf-static command to seg fault: > QPixmap: Cannot create a QPixmap when no GUI is being used > ... > Segmentation fault Also need to remove JS from the page as this causes SSL socket errors: > QSslSocket: cannot resolve ... > QSslSocket: cannot call unresolved function ... Fixes #6435
gbp
force-pushed
the
6435-fix-pdf-downloads
branch
from
e236cc3
to
b392efd
Compare
gbp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #6435
What does this do?
Remove popup banner and JS from show request PDFs
Why was this needed?
We need to remove the popup due to WDTK theme using opacity CSS selector
for these elements this is causing the wkhtmltopdf-static command to seg
fault:
Also need to remove JS from the page as this causes SSL socket errors: