[#6659] Add deprecation warning for HTML_TO_PDF_COMMAND #6660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As with other external commands we need are only going to support one option (`wkhtmltopdf`). Doing so will make it easier to pass command specific arguments to the tool in order to support later versions. See: #6489
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #6659
What does this do?
Add deprecation warning for HTML_TO_PDF_COMMAND
Why was this needed?
As with other external commands we need are only going to support one
option (
wkhtmltopdf). Doing so will make it easier to pass commandspecific arguments to the tool in order to support later versions.
See: #6489
Implementation notes
Will mean release 0.40 will see deprecation notices which we normally resolve before release but this isn't a heavily used feature so is fine for now.