Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#6659] Add deprecation warning for HTML_TO_PDF_COMMAND #6660

Merged
merged 1 commit into from Nov 12, 2021
Merged

[#6659] Add deprecation warning for HTML_TO_PDF_COMMAND #6660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions doc/CHANGES.md
View file
Open in desktop
Expand Up @@ -55,6 +55,11 @@
* Support for Ubuntu Bionic (18.04 LTS) will be removed in or after the next
release.
* Support for Debian 9 Stretch will be removed in or after the next release.
* We will remove the `HTML_TO_PDF_COMMAND` configuration variable in the next
release. If you aren't already using `wkhtmltopdf` please switch and ensure
the path to this command is include in the `UTILITY_SEARCH_PATH` configuration
variable. For release 0.40 we only support the wkhtmltopdf v0.11. Support for
the latest v0.12 version will be added in the next release.
* You might see `git protocol on port 9418 is no longer supported` when
deploying. Please switch to `https` for any theme repo URLs in your
`config/general.yml` See: https://github.com/mysociety/alaveteli/pull/6630
Expand Down
9 changes: 9 additions & 0 deletions lib/configuration.rb
View file
Open in desktop
Expand Up @@ -136,6 +136,15 @@ module AlaveteliConfiguration
# rubocop:enable Layout/LineLength
end

def self.html_to_pdf_command
warn <<~DEPRECATION.squish
[DEPRECATION] AlaveteliConfiguration.html_to_pdf_command will be removed
in 0.41. Please add the directory containing the wkhtmltopdf command to
AlaveteliConfiguration.utility_search_path
DEPRECATION
super
end

def self.method_missing(name)
key = name.to_s.upcase
if DEFAULTS.has_key?(key.to_sym)
Expand Down