[#7184] Fix unknown notification mailer method #7200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename `expire_embargo_notification` to `embargo_expired_notification` as this method was misnamed. Exceptions occurred when an embargo expires and the requester uses instant notifications. When on daily notification no exceptions would occur. Fixes #7184
garethrees
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #7184
What does this do?
Rename
expire_embargo_notificationtoembargo_expired_notificationas this method was misnamed.
Why was this needed?
Exceptions occurred when an embargo expires and the requester uses
instant notifications. When on daily notification no exceptions would
occur.
Implementation notes
Opted to not rename
factoriesandletsvariables as these read better asembargo_expired_....