[#5851] Review new framework defaults #8120
Open
+2
−311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added so we can review these options.
gbp
force-pushed
the
review-new-framework-defaults
branch
from
4ed6ccb
to
3af87a4
Compare
|
This is on deployed to staging. I'm thinking this might be good to merge but will see if there are issues when testing other features on there. |
gbp
commented
Apr 30, 2024
| @@ -31,6 +31,7 @@ class Application < Rails::Application | |||
| # | |||
| # config.time_zone = "Central Time (US & Canada)" | |||
| # config.eager_load_paths << Rails.root.join("extras") | |||
| config.load_defaults = 7.0 | |||
There was a problem hiding this comment.
This PR isn't doing anything - we need to call the #load_defaults method!
Suggested change
| config.load_defaults = 7.0 | |
| config.load_defaults 7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #5851
What does this do?
Lazy review of the new framework defaults. Testing to see if the specs pass with the new defaults used.
Why was this needed?
So we can upgrade Rails further.