Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5851] Review new framework defaults #8120

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions config/application.rb
Expand Up @@ -31,6 +31,7 @@ class Application < Rails::Application
#
# config.time_zone = "Central Time (US & Canada)"
# config.eager_load_paths << Rails.root.join("extras")
config.load_defaults = 7.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR isn't doing anything - we need to call the #load_defaults method!

Suggested change
config.load_defaults = 7.0
config.load_defaults 7.0

config.autoloader = :zeitwerk
config.active_record.legacy_connection_handling = false
config.active_support.use_rfc4122_namespaced_uuids = true
Expand Down
20 changes: 0 additions & 20 deletions config/initializers/new_framework_defaults.rb

This file was deleted.

38 changes: 0 additions & 38 deletions config/initializers/new_framework_defaults_5_2.rb

This file was deleted.

45 changes: 0 additions & 45 deletions config/initializers/new_framework_defaults_6_0.rb

This file was deleted.

67 changes: 0 additions & 67 deletions config/initializers/new_framework_defaults_6_1.rb

This file was deleted.

141 changes: 0 additions & 141 deletions config/initializers/new_framework_defaults_7_0.rb

This file was deleted.

1 change: 1 addition & 0 deletions doc/CHANGES.md
Expand Up @@ -2,6 +2,7 @@

## Highlighted Features

* Update Rails application framework defaults (Graeme Porteous)
* Allow categories to have notes associated with them (Graeme Porteous)
* Add styling option and rich text editor to the notes admin (Graeme Porteous)
* Strengthen 2FA warning. Users *must* remember to keep this code safe (Gareth
Expand Down