Draft Methodology 2025 feedback #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucascumsille
changed the title
zarino
force-pushed
the
2025_methodoloy_feedback_v2
branch
2 times, most recently
from
a6ce6fa
to
ca64e45
Compare
zarino
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
I’ve pushed a few fixup commits as we discussed last week – using the position of the nav, rather than its background colour, for emphasis, and switching to purple for the nav link colours.
I‘ve also added a commit that overrides .bg-primary-* styles inside a .year-2025 container, which feels like it might become more and more useful as we start adding more 2025 pages to the site. Eventually, I guess, we’ll replace the *-primary2025 styles entirely, and rely just on this .year-2025 inheritance.
- Move in-page nav to left-hand column - Purple links in in-page nav - White background for in-page nav on mobile (rather than transparent)
Also fix broken background color on main-filter-methodology component, making it much more noticeable on the Methodology page.
zarino
force-pushed
the
2025_methodoloy_feedback_v2
branch
from
ca64e45
to
007a470
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes row 22 and 23:
https://docs.google.com/spreadsheets/d/19W5anmr3VIgNmR9uN--SV6fC96AIwYx29WGnbJyb6Eo/edit?pli=1#gid=63266911