Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve admin report edit page, and tidy up local coordinate handling #1442

Merged
merged 4 commits into from
Jun 29, 2016

Conversation

dracos
Copy link
Member

@dracos dracos commented Jun 24, 2016

No description provided.

<li class="sm">[% loc('Confirmed:') %] [% PROCESS format_time time=problem.confirmed no_time='-' %]</li>
<li class="sm">[% loc('Sent:') %] [% PROCESS format_time time=problem.whensent %]
[% IF problem.send_method_used %]
([% send_method_used %])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be problem.send_method_used

@davea
Copy link
Member

davea commented Jun 28, 2016

This is awesome, it makes the admin view much nicer to work with.

IMO the lists look better with list-style: none, and I couldn't figure out the pattern of certain items being class='sm'. Other than that, 👍

@davea davea added Reviewed and removed Reviewing labels Jun 28, 2016
Show map, break into two columns, fix display of sent time after
clicking "Mark as sent", tidy up labels.
Show bodies for which details are missing, and any send method used.
@dracos dracos merged commit 5cf9a81 into master Jun 29, 2016
@dracos dracos removed the Reviewed label Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants