Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixmystreet.com] FMS Pro banner on homepage #1709

Merged
merged 2 commits into from
May 23, 2017

Conversation

zarino
Copy link
Member

@zarino zarino commented May 22, 2017

Big yellow box at the bottom of the FMS.com homepage to lead council users towards the councils marketing page (#1699). Kept purposefully simple, so we could just get something out there quickly.

Includes a new, brighter tile.jpg, to improve text contrast and to match the $primary colour of #FFD000.

The "Are you a developer?" heading has also been removed from footer-marketing.html in most of the cobrands (including fixmystreet.com) and the general styling of that footer section tidied up on narrow and wide screens for all of the cobrands that inherit directly from the default cobrand.

Fixes mysociety/FixMyStreet-Commercial#815.

FMS.com: Narrow screens

screen shot 2017-05-22 at 16 06 33

FMS.com: Wide screens

screen shot 2017-05-22 at 16 06 12

Default: Narrow screens

screen shot 2017-05-23 at 12 12 29

Default: Wide screens

screen shot 2017-05-23 at 12 12 12

@zarino zarino requested a review from dracos May 22, 2017 15:08
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Little chat in Slack about tweaking something similar in the base cobrand.

@dracos dracos added Reviewed and removed Reviewing labels May 23, 2017
@zarino zarino force-pushed the issues/commercial/815-fms-pro-section-on-homepage branch 2 times, most recently from 45a1ada to 4c12dff Compare May 23, 2017 11:43
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved again

Includes a new, brighter tile.jpg, to improve text contrast and
to match the $primary colour of #FFD000.
@zarino zarino force-pushed the issues/commercial/815-fms-pro-section-on-homepage branch from 4c12dff to cd48d6c Compare May 23, 2017 12:03
@zarino zarino merged commit cd48d6c into master May 23, 2017
@zarino zarino removed the Reviewed label May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants