New version of /reports main page. #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracos
force-pushed
the
new-reports-in-core
branch
from
85a1e6d
to
93e973a
Compare
dracos
force-pushed
the
new-reports-in-core
branch
from
93e973a
to
ae128a2
Compare
dracos
added a commit
that referenced
this pull request
Jul 8, 2017
This will need redoing if #1753 is merged first.
Merged
dracos
added a commit
that referenced
this pull request
Jul 14, 2017
This will need redoing if #1753 is merged first.
This is a much broader summary page, plus a body name autocomplete. This was originally implemented for fixmystreet.com in 8a6a4cc. It also adds '(no longer exists)' in the autocomplete next to bodies not covering any areas. You can supply the `--table` argument to `update-all-reports` to generate the old-style data.
dracos
force-pushed
the
new-reports-in-core
branch
from
ae128a2
to
f604fb2
Compare
Codecov Report
@@ Coverage Diff @@
## master #1753 +/- ##
==========================================
+ Coverage 71.64% 72.03% +0.39%
==========================================
Files 153 153
Lines 9847 9828 -19
Branches 1783 1782 -1
==========================================
+ Hits 7055 7080 +25
+ Misses 2126 2078 -48
- Partials 666 670 +4
Continue to review full report at Codecov.
|
davea
approved these changes
Jul 14, 2017
There was a problem hiding this comment.
(if you copy the old template into your cobrand, it should continue to work fine).
CMC has done this, and it does!
Good idea to include a flag for backwards compatibility 🎉 As this is a breaking change for anyone who's overridden the reports/index.html template (any idea of who's done this?) we should highlight it in the 2.1 release notes.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a much broader summary page, plus a body name autocomplete.
This was originally implemented for fixmystreet.com in 8a6a4cc.
(It also adds '(no longer exists)' in the autocomplete next to bodies not covering any areas.)
You can supply the
--tableargument toupdate-all-reportsto generate the old-style data (if you copy the old template into your cobrand, it should continue to work fine).