Make it easier to prevent a form_detail_placeholder being printed #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarino
added a commit
to mysociety/collideoscope
that referenced
this pull request
Aug 17, 2018
Requires mysociety/fixmystreet#2212 in core.
Codecov Report
@@ Coverage Diff @@
## master #2212 +/- ##
=========================================
Coverage ? 79.46%
=========================================
Files ? 182
Lines ? 11830
Branches ? 2206
=========================================
Hits ? 9401
Misses ? 1665
Partials ? 764Continue to review full report at Codecov.
|
dracos
approved these changes
Aug 20, 2018
| @@ -49,13 +49,22 @@ <h2 class="form-section-heading">[% loc( 'Public details' ) %]</h2> | |||
| [% TRY %][% PROCESS 'report/new/after_photo.html' %][% CATCH file %][% END %] | |||
|
|
|||
| [% DEFAULT form_detail_label = loc('Explain what’s wrong') %] | |||
| [% DEFAULT form_detail_placeholder = loc('e.g. ‘This pothole has been here for two months and…’') %] | |||
There was a problem hiding this comment.
What you have works fine, but I wonder if it would be clearer if this line became [% IF NOT form_detail_placeholder.defined %][% SET form_detail_placeholder = ... %][% END %] and then below would be [% IF form_detail_placeholder %]... without needing to duplicate e.g. the aria_describedby line. What do you think? Not much in it.
zarino
force-pushed
the
optional-details-hint
branch
from
df076c0
to
3d3d940
Compare
dracos
approved these changes
Aug 20, 2018
Previously, if you didn’t want a hint to appear under the main "details" textarea on the new report form, you had to override the entire `form_report.html` template, or leave the hint element in the markup but hide it with CSS. Now, you can set `form_detail_placeholder` to a falsey value, and the template won’t output the hint element at all. It also amends the `aria-describedby` attribute on the textarea so it doesn’t end up referencing a hint element that doesn’t exist.
zarino
force-pushed
the
optional-details-hint
branch
from
3d3d940
to
0caded8
Compare
zarino
added a commit
to mysociety/collideoscope
that referenced
this pull request
Aug 20, 2018
Requires mysociety/fixmystreet#2212 in core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if you didn’t want a hint to appear under the main "details" textarea on the new report form, you had to override the entire
form_report.htmltemplate, or leave the hint element in the markup but hide it with CSS.Now, you can set
form_detail_placeholderto a falsey value, and the template won’t output the hint element at all. It also amends thearia-describedbyattribute on the textarea so it doesn’t end up referencing a hint element that doesn’t exist.I needed this for mysociety/collideoscope#28, because the existing
[% DEFAULT form_detail_placeholder = … %]block gave me no easy way to prevent the hint being shown.How it looks:
When no custom
form_detail_placeholderis defined in the cobrand, eg:When a custom
form_detail_placeholderis defined in the cobrand, eg:NEW: When
form_detail_placeholderis set to a falsey value, eg: