Allow moderation to potentially change photos. #2291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #2291 +/- ##
==========================================
- Coverage 80.24% 80.16% -0.09%
==========================================
Files 187 187
Lines 12039 12035 -4
Branches 2224 2224
==========================================
- Hits 9661 9648 -13
- Misses 1617 1630 +13
+ Partials 761 757 -4
Continue to review full report at Codecov.
|
dracos
force-pushed
the
add-photo-to-report
branch
3 times, most recently
from
3b341b6
to
d7d6f99
Compare
struan
approved these changes
Oct 16, 2018
| $c->forward('/photo/process_photo'); | ||
| #if ( my $photo_error = delete $c->stash->{photo_error} ) { | ||
| # What to do here? | ||
| #} |
|
Some fixups for the error, test, and then to prevent clashes with the update photo upload (both JS only looking for one form, and server not putting the problem photos in the update photo upload preview). |
struan
approved these changes
Oct 19, 2018
dracos
force-pushed
the
add-photo-to-report
branch
from
70b83e9
to
1e5b99f
Compare
As well as the original form using #form_photo, add Dropzone to any form with a .js-photo-label in it.
dracos
force-pushed
the
add-photo-to-report
branch
from
1e5b99f
to
c73e8b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets a cobrand provide a standard photo upload form (as on new report/update) in the report display so moderation can add/remove photos to a report, not just show/hide.