-
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow state editing via moderation. #2381
Conversation
c7fb65a
to
eead5a5
Compare
eead5a5
to
4b91adf
Compare
Codecov Report
@@ Coverage Diff @@
## master #2381 +/- ##
=========================================
+ Coverage 80.68% 80.7% +0.02%
=========================================
Files 192 192
Lines 12314 12328 +14
Branches 2287 2293 +6
=========================================
+ Hits 9935 9949 +14
+ Misses 1613 1612 -1
- Partials 766 767 +1
Continue to review full report at Codecov.
|
4b91adf
to
6ac3d6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small query but otherwise, this looks good.
$problem->state($new_state); | ||
$problem->update; | ||
$problem->add_to_comments( { | ||
text => $c->stash->{moderation_reason}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally this doesn't get made public so is that not going to be a bit unexpected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, so this won't be on .com, only on a cobrand that's deliberately added state to the moderation form (like kiitc) where it's clearer it's a public editing, but yes, I guess it still might be odd. Guess I'll add a comment here at least about thinking about that for any other cobrand that might use it.
6ac3d6e
to
cf55bd3
Compare
If a state is passed in (on a cobrand), update problem state and add a comment to record this (as state changes are updates not moderations).
cf55bd3
to
be0944d
Compare
If a state is passed in (on a cobrand), update problem state and add a comment to record this (as state changes are updates not moderations).