Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 403/private report error messages. #2511

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

dracos
Copy link
Member

@dracos dracos commented Jun 11, 2019

[skip changelog]

@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #2511 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2511      +/-   ##
==========================================
+ Coverage   82.16%   82.17%   +<.01%     
==========================================
  Files         211      211              
  Lines       13045    13049       +4     
  Branches     2395     2395              
==========================================
+ Hits        10719    10723       +4     
  Misses       1493     1493              
  Partials      833      833
Impacted Files Coverage Δ
perllib/FixMyStreet/App/Controller/Root.pm 95.52% <100%> (+0.13%) ⬆️
perllib/FixMyStreet/App/Controller/Report.pm 91.54% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afca06d...c6acc64. Read the comment docs.

@dracos dracos force-pushed the issues/commercial/1417-better-private-message branch from 3ee903a to 72459c7 Compare June 11, 2019 15:57
@dracos dracos requested a review from davea June 13, 2019 09:35
Copy link
Member

@davea davea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 👍

@dracos dracos force-pushed the issues/commercial/1417-better-private-message branch from 72459c7 to c6acc64 Compare June 14, 2019 10:00
@dracos dracos merged commit c6acc64 into master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants