[Westminster] Add OpenID Connect single sign-on support #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## westminster-reviewed #2523 +/- ##
========================================================
+ Coverage 82.32% 82.35% +0.03%
========================================================
Files 211 214 +3
Lines 13085 13187 +102
Branches 2417 2439 +22
========================================================
+ Hits 10772 10860 +88
- Misses 1476 1480 +4
- Partials 837 847 +10
Continue to review full report at Codecov.
|
zarino
force-pushed
the
issues/community/57-westminster-cobrand
branch
from
97456ae
to
7b8d65c
Compare
dracos
force-pushed
the
issues/community/57-westminster-cobrand
branch
from
7b8d65c
to
385bf4e
Compare
davea
force-pushed
the
westminster-sso
branch
2 times, most recently
from
5e9c8f1
to
d1cd01c
Compare
dracos
requested changes
Jul 1, 2019
| $c->res->redirect($url); | ||
| } | ||
|
|
||
| sub oidc_callback: Path('/auth/OIDC') : Args(0) { |
There was a problem hiding this comment.
I realise they're all subtly different, but is there any worth in factoring the (now) three out to shared subclasses or something with variants for their differing parts?
dracos
reviewed
Jul 2, 2019
dracos
force-pushed
the
issues/community/57-westminster-cobrand
branch
4 times, most recently
from
7a65687
to
6790083
Compare
dracos
changed the base branch from
issues/community/57-westminster-cobrand
to
westminster-reviewed
dracos
requested changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends social login functionality to authenticate against an (MS Active Directory B2C-specific) OpenID Connect identity provider.