Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not store display-only extra fields on reports. #2560

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

dracos
Copy link
Member

@dracos dracos commented Jul 12, 2019

@dracos dracos requested a review from struan July 12, 2019 14:12
Copy link
Member

@struan struan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

Merging #2560 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2560      +/-   ##
==========================================
- Coverage   82.37%   82.36%   -0.01%     
==========================================
  Files         210      210              
  Lines       13075    13079       +4     
  Branches     2417     2417              
==========================================
+ Hits        10770    10773       +3     
  Misses       1468     1468              
- Partials      837      838       +1
Impacted Files Coverage Δ
perllib/FixMyStreet/DB/Result/Contact.pm 100% <100%> (ø) ⬆️
perllib/FixMyStreet/App/Controller/Report/New.pm 87.57% <100%> (ø) ⬆️
perllib/Utils.pm 97.97% <0%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63d6df8...ab3799a. Read the comment docs.

@dracos dracos merged commit ab3799a into master Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants