Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'disable_form' flag to category extras #2599

Merged
merged 3 commits into from
Aug 29, 2019

Conversation

davea
Copy link
Member

@davea davea commented Aug 14, 2019

This replaces the cobrand-JS-specific way of adding messages that disable the report form with a new 'disable form' tickbox in the admin.

Fixes https://github.com/mysociety/fixmystreet-commercial/issues/1515

@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #2599 into master will increase coverage by <.01%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2599      +/-   ##
==========================================
+ Coverage   82.25%   82.26%   +<.01%     
==========================================
  Files         215      215              
  Lines       13451    13469      +18     
  Branches     2489     2496       +7     
==========================================
+ Hits        11064    11080      +16     
  Misses       1525     1525              
- Partials      862      864       +2
Impacted Files Coverage Δ
perllib/FixMyStreet/App/Controller/Admin.pm 80.91% <100%> (-0.08%) ⬇️
perllib/FixMyStreet/App/Controller/Report/New.pm 89.17% <88.23%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2729d3...7a8dcd6. Read the comment docs.

@dracos dracos force-pushed the issues/1515-disable-form-flag branch from b04c44f to 7671ed9 Compare August 22, 2019 14:18
@dracos dracos marked this pull request as ready for review August 22, 2019 15:42
@dracos dracos requested a review from struan August 22, 2019 15:42
@dracos dracos force-pushed the issues/1515-disable-form-flag branch 2 times, most recently from 04e85b5 to c3e5e72 Compare August 23, 2019 13:37
Copy link
Member

@struan struan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing with adding new options, but otherwise, yay, this is lovely.

@dracos dracos force-pushed the issues/1515-disable-form-flag branch 2 times, most recently from 975610a to 07c1728 Compare August 29, 2019 13:28
@dracos dracos force-pushed the issues/1515-disable-form-flag branch from 07c1728 to 0e5a3a1 Compare August 29, 2019 17:06
davea and others added 2 commits August 29, 2019 18:12
Remove all existing hard-coded register_category calls, and have
a new way of implementing staff_ignore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants