Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add way to disallow report reopening on reports in a category #3012

Merged
merged 1 commit into from
May 7, 2020

Conversation

dracos
Copy link
Member

@dracos dracos commented May 1, 2020

Fixes #2992. Fixes https://github.com/mysociety/fixmystreet-commercial/issues/1872.
Does need a doc update but I will do that at same time as #2991 doc given it'll be same screenshot, same place. In fact, might as well wait for #2989 to only do the screenshot once!

Includes same first commit as mentioned in #3011

@dracos dracos requested a review from davea May 1, 2020 15:36
@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #3012 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3012   +/-   ##
=======================================
  Coverage   83.02%   83.03%           
=======================================
  Files         246      246           
  Lines       15385    15388    +3     
  Branches     2869     2870    +1     
=======================================
+ Hits        12774    12777    +3     
  Misses       1695     1695           
  Partials      916      916           
Impacted Files Coverage Δ
perllib/FixMyStreet/App/Controller/Admin/Bodies.pm 96.45% <100.00%> (ø)
perllib/FixMyStreet/Cobrand/Default.pm 86.31% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0d1dc...f6d807f. Read the comment docs.

Copy link
Member

@davea davea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I like this approach, looks good. A couple of little things but nothing major.

perllib/FixMyStreet/Cobrand/Default.pm Outdated Show resolved Hide resolved
templates/web/base/admin/bodies/contact-form.html Outdated Show resolved Hide resolved
Add a tickbox to the category admin, and do not allow reopening on
reports made in the selected categories.
@dracos dracos force-pushed the 2992-reopen-on-categories branch from 4b9496a to f6d807f Compare May 7, 2020 09:54
@dracos dracos merged commit cfabb3c into master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow reopening only on certain categories
2 participants