Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include category group in CSV export #3016

Merged
merged 1 commit into from
May 7, 2020
Merged

Conversation

dracos
Copy link
Member

@dracos dracos commented May 4, 2020

Fixes #2994
Fixes https://github.com/mysociety/fixmystreet-commercial/issues/1874

First commit is shared with #3011 and #3012 to allow the group lookup to be done as part of the normal DB call.

@dracos dracos requested a review from davea May 4, 2020 15:35
@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #3016 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3016   +/-   ##
=======================================
  Coverage   83.02%   83.03%           
=======================================
  Files         246      246           
  Lines       15385    15376    -9     
  Branches     2869     2871    +2     
=======================================
- Hits        12774    12768    -6     
  Misses       1695     1695           
+ Partials      916      913    -3     
Impacted Files Coverage Δ
perllib/FixMyStreet/Cobrand/Bexley.pm 85.71% <ø> (-0.55%) ⬇️
perllib/FixMyStreet/Cobrand/TfL.pm 85.12% <ø> (+0.12%) ⬆️
perllib/FixMyStreet/DB/ResultSet/Contact.pm 100.00% <ø> (ø)
perllib/FixMyStreet/App/Controller/Dashboard.pm 90.49% <100.00%> (+0.41%) ⬆️
perllib/FixMyStreet/App/Controller/Admin/Users.pm 86.18% <0.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0d1dc...a2cc36b. Read the comment docs.

@dracos dracos merged commit cfabb3c into master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include category group in CSV export
2 participants