Improved email phone in form #3191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3191 +/- ##
==========================================
+ Coverage 83.66% 83.69% +0.03%
==========================================
Files 251 251
Lines 15744 15778 +34
Branches 2942 2952 +10
==========================================
+ Hits 13172 13206 +34
Misses 1639 1639
Partials 933 933
Continue to review full report at Codecov.
|
dracos
force-pushed
the
improved-email-phone-in-form
branch
from
7f0cdce
to
9e49ef9
Compare
dracos
force-pushed
the
improved-email-phone-in-form
branch
from
9e49ef9
to
368c321
Compare
struan
requested changes
Sep 24, 2020
dracos
force-pushed
the
improved-email-phone-in-form
branch
from
368c321
to
dba30f9
Compare
struan
requested changes
Sep 25, 2020
If a staff user is reporting as another user, and gives an invalid email address, for example.
Rename the not-logging-in username field to username_register. Keep the sign-in field as username because that e.g. overlaps with auth code in two-factor authentication.
dracos
force-pushed
the
improved-email-phone-in-form
branch
from
dba30f9
to
82a3e9b
Compare
struan
requested changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does three things:
And then one I am not sure about:
3. It splits the dual-use username field into username (signing in form) and username_register (confirm by code). I think this might help with obscure errors where e.g. if new report form submission to server has a problem, it would display the username in both fields client-side, which would then cause an issue on next submission if you only altered the one you could see, not realising there was another. I did not rename username to username_sign_in (I did get halfway through, sigh) because it starts to interact with the auth code e.g. with 2FA and change password etc and I didn't want to affect them (I mean, hopefully I haven't!).