Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved email phone in form #3191

Merged
merged 6 commits into from
Sep 30, 2020
Merged

Improved email phone in form #3191

merged 6 commits into from
Sep 30, 2020

Commits on Sep 25, 2020

  1. Show username error in correct place only.

    @dracos
    dracos committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    ba1179d View commit details
    Browse the repository at this point in the history

  2. Show username error, in case reporting as another. 

    If a staff user is reporting as another user, and gives an invalid
email address, for example.
    @dracos
    dracos committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    a38ecfb View commit details
    Browse the repository at this point in the history

  3. If text auth on, ask which method they wish to use

    @dracos
    dracos committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    85a6b7d View commit details
    Browse the repository at this point in the history

  4. Split up two username fields. 

    Rename the not-logging-in username field to username_register.
Keep the sign-in field as username because that e.g. overlaps
with auth code in two-factor authentication.
    @dracos
    dracos committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    22cc2b0 View commit details
    Browse the repository at this point in the history

  5. Make sure JS error is not within segmented control

    @dracos
    dracos committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    82a3e9b View commit details
    Browse the repository at this point in the history

  6. Show error if text confirmation code sending fails

    @dracos
    dracos committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    2abe443 View commit details
    Browse the repository at this point in the history