[Brent] Allow reporting of missed small items if overdue #4736
Conversation
Allow open small items events through and check if they are overdue. If they are allow them to be reported as missed. https://mysocietysupport.freshdesk.com/a/tickets/3500
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4736 +/- ##
==========================================
+ Coverage 85.19% 85.95% +0.75%
==========================================
Files 339 340 +1
Lines 24149 26764 +2615
Branches 4547 5354 +807
==========================================
+ Hits 20574 23005 +2431
- Misses 2193 2281 +88
- Partials 1382 1478 +96 ☔ View full report in Codecov by Sentry. |
| my $report = $self->problems->search({ external_id => $_->{Guid} })->first; | ||
| $events->{enquiry}->{$event_type} = { | ||
| report => $report, | ||
| date => construct_bin_date($_->{DueDate}), |
There was a problem hiding this comment.
I'm not sure we can trust DueDate is the date of the collection, I'm not sure that's documented anywhere. Can we read it from $report->get_extra_field_value('CollectionDate') instead?
Clarify that construct_bin_date requires a hash ref and return if hash ref doesn't contain required key
There was a problem hiding this comment.
One query to ask Brent about, I guess.
Not necessarily wanting to expand this, but from K&S work I see that this code won't work if someone has more than one bulky collection active - we're only ever storing one such here. Do you think it would be much work to have it store multiple if it finds them, and use them?
| my $report = $self->problems->search({ external_id => $_->{Guid} })->first; | ||
| $events->{enquiry}->{$event_type} = { | ||
| report => $report, | ||
| date => construct_bin_date({ DateTime => $report->get_extra_field_value('Collection_Date')}), |
There was a problem hiding this comment.
We may fetch an event with this API call that doesn't exist in our system (if it was created outside our system), so I guess in that case we shouldn't set this object at all, as we won't know the collection date then. (Also, we could ask Brent if there is a field on a bulky collection event that is the collection date, and then use that (perhaps I should have suggested asking that in my last comment).)
Allow open small items events through and check if they are overdue. If they are allow them to be reported as missed.
https://mysocietysupport.freshdesk.com/a/tickets/3500
[skip changelog]