Factor together West/North Northamptonshire cobrands #4872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## north-northants-setup #4872 +/- ##
=========================================================
- Coverage 82.70% 82.64% -0.06%
=========================================================
Files 388 391 +3
Lines 30495 30580 +85
Branches 4823 4832 +9
=========================================================
+ Hits 25222 25274 +52
- Misses 3821 3851 +30
- Partials 1452 1455 +3 ☔ View full report in Codecov by Sentry. |
neprune
force-pushed
the
northants-refactor
branch
from
c795278
to
ac0a272
Compare
neprune
force-pushed
the
north-northants-setup
branch
from
168988c
to
32c4784
Compare
neprune
force-pushed
the
northants-refactor
branch
from
ac0a272
to
e65a22f
Compare
neprune
force-pushed
the
north-northants-setup
branch
from
32c4784
to
6987ef3
Compare
neprune
force-pushed
the
northants-refactor
branch
from
e65a22f
to
e1fb777
Compare
davea
force-pushed
the
northants-refactor
branch
from
e1fb777
to
b86ba22
Compare
This element will now behave like the `.btn` element in terms of styling. This way we don't need to worry about contrast and we can still use the branding of each cobrand.
This has been added after header elements and before any focusable map elements, that way the user doesn't need to go through the map links and compass to be able to go to skip the map.
Element #front-main has been changed from `div` to a `main`` element. This should improve the semantic and accessibility for this page.
Element #front-main has been changed from `div` to a `main`` element. This should improve the semantic and accessibility for this page.
Could probably benefit from some factoring together with West Northants, but seems a decent enough start.
This really obscures the logo on this cobrand. Setting opacity to 0 seemed the best way to make it disappear without flickering, which happened with visibility: hidden, display: none, left: -99999px, etc.
neprune
force-pushed
the
northants-refactor
branch
from
b86ba22
to
893e9cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4157