Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brent] Extra container request workflow #4877

Merged
merged 6 commits into from
Jul 1, 2024
Merged

Conversation

dracos
Copy link
Member

@dracos dracos commented Mar 13, 2024

@dracos dracos requested a review from davea March 13, 2024 13:01
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.66%. Comparing base (56d05c5) to head (eba9449).

Files Patch % Lines
perllib/FixMyStreet/Cobrand/Brent.pm 85.71% 0 Missing and 2 partials ⚠️
perllib/FixMyStreet/Roles/Cobrand/Echo.pm 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4877      +/-   ##
==========================================
+ Coverage   82.62%   82.66%   +0.03%     
==========================================
  Files         396      396              
  Lines       30818    30819       +1     
  Branches     4884     4889       +5     
==========================================
+ Hits        25464    25476      +12     
+ Misses       3907     3897      -10     
+ Partials     1447     1446       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This will allow different parameters to be provided where needed.
This will be then used to route requests appropriately.
@dracos dracos merged commit eba9449 into master Jul 1, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants