[Bexley][WW] Fetch successful collections alongside other in-cab logs

[nephila-nacrea]

For https://3.basecamp.com/4020879/buckets/35109031/todos/7411178677.

Logs with a reason of 'N/A' were being ignored, but we need them to check whether a collection has already been made today for a given service.

[skip changelog]

[codecov]

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 82.60%. Comparing base (cf1ca81) to head (78fabdd).

Files	Patch %	Lines
perllib/FixMyStreet/Cobrand/Bexley/Waste.pm	77.77%	0 Missing and 4 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4969   +/-   ##
=======================================
  Coverage   82.59%   82.60%           
=======================================
  Files         393      393           
  Lines       30751    30756    +5     
  Branches     4876     4877    +1     
=======================================
+ Hits        25400    25405    +5     
+ Misses       3898     3897    -1     
- Partials     1453     1454    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chrismytton]

I think this is a step in the right direction, but we also need to allow for the fact that there aren't always round completion logs, so the presence of any log should be taken as a sign that the round has been completed.

See this Basecamp message and the subsequent discussions for details about this problem.

The fix I did was 6ca9636, which gets logs for all UPRNs under the relevant USRN, which meant because the code was checking property and street logs it would allow a report if there was a red tag log against the street (but lock the user out if the red tag was against one of their containers).

Guess we could have the _in_cab_logs method just return all logs and then add some other methods that filter down the list of logs to look for ones we're interested in, which I think is:

• Red tags for the current property
• Service updates for the street ("No access" type things, I assume)
• Round completion indicters
  • Any kind of logs within the relevant USRN on the relevant date can be taken as an indictor of round completion, I think.

Sorry!

[chrismytton]

Yay, this is a huge improvement!

I think as discussed in Slack it would be good to just use the USRN logs, but that can be done in a separate PR.

In the meantime lets get this change on staging for them 🙂

[chrismytton]

🤣