Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement standard mysociety footer on UK and Global MapIt #238

Merged
merged 2 commits into from May 27, 2016

Conversation

zarino
Copy link
Member

@zarino zarino commented May 11, 2016

Fixes mysociety/mapit.mysociety.org#17.

Requires Sass 3.2 or greater, since it uses % placeholder selectors.

screen shot 2016-05-11 at 15 15 09

@dracos dracos added the Current label May 11, 2016
@@ -0,0 +1 @@
Points-to-boundary mapping, anywhere in the world. Input a zipcode or geographical location, and MapIt returns the relevant constituency or authority.
Copy link
Member

@dracos dracos May 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There aren't any zipcodes in the global installation; 'administrative area' instead of 'constituency or authority', I think.
And "Point to boundary mapping", as you can only do one at a time :)

@zarino
Copy link
Member Author

zarino commented May 25, 2016

@dracos I've made the text changes you suggested. Can you merge and deploy this?

@dracos
Copy link
Member

dracos commented May 27, 2016

This won't deploy until code is added to bring in a more recent version of sass than that installed on the servers. I'll hopefully be able to look at this today given I'm doing MapIt data updating anyway.

zarino and others added 2 commits May 27, 2016 13:11
Fixes mysociety/mapit.mysociety.org#17.

Requires Sass 3.2 or greater, since it uses `%` placeholder
selectors.
This means we don't have to worry about whether sass has been installed.
@dracos dracos merged commit 53ee40c into master May 27, 2016
@dracos dracos removed the Reviewed label May 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants