[EastSussex] optionally set a sort order on question answers

if the question has an order key then use that to sort the list of answers
mysociety · Apr 29, 2020 · 2ba2363 · 2ba2363
1 parent 4c11ded
commit 2ba2363
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/perllib/Open311/Endpoint/Integration/SalesForceRest.pm b/perllib/Open311/Endpoint/Integration/SalesForceRest.pm
@@ -190,6 +190,7 @@ sub service {
             if ($q->{answers}) {
                 $attribs->{datatype} = 'singlevaluelist';
                 $attribs->{values} = { map { ref $_ eq 'ARRAY' ? ( $_->[0] => $_->[1] ) : ( $_ => $_ ) } @{ $q->{answers} } };
+                $attribs->{values_sorted} = [ map {  ref $_ eq 'ARRAY' ? $_->[0] : $_ } @{ $q->{answers} } ] if $q->{maintain_order};
             }
 
             push @{ $service->attributes }, Open311::Endpoint::Service::Attribute->new($attribs);

diff --git a/t/open311/endpoint/eastsussex.t b/t/open311/endpoint/eastsussex.t
@@ -524,14 +524,14 @@ subtest "check fetch service description with questions" => sub {
             order => 4,
             description => "What is the problem with the sign?",
             values => [
-                {
-                    name => "broken",
-                    key => "broken",
-                },
                 {
                     name => "dirty",
                     key => "dirty",
                 },
+                {
+                    name => "broken",
+                    key => "broken",
+                },
                 {
                     name => "sign is incorrect",
                     key => "incorrect",

diff --git a/t/open311/endpoint/eastsussex.yml b/t/open311/endpoint/eastsussex.yml
@@ -66,6 +66,7 @@
       "signQuestions": [
         {
           question: "What is the problem with the sign?",
+          maintain_order: 1,
           answers: [
             "dirty",
             "broken",