Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Central Beds] Fetch updates directly from Symology API #164

Merged

Conversation

davea
Copy link
Member

@davea davea commented Nov 26, 2020

The CSVs don't include everything we need to generate updates for FixMyStreet, so this PR calls into the Symology API for each enquiry in the CSV file and builds the Open311 ServiceRequestUpdates from the Symology history events.

@davea davea requested a review from dracos November 26, 2020 19:06
@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #164 (4be610f) into central-beds-symology-reviewed (05bc833) will increase coverage by 0.11%.
The diff coverage is 90.56%.

Impacted file tree graph

@@                        Coverage Diff                         @@
##           central-beds-symology-reviewed     #164      +/-   ##
==================================================================
+ Coverage                           78.38%   78.49%   +0.11%     
==================================================================
  Files                                  84       84              
  Lines                                3821     3869      +48     
  Branches                              564      572       +8     
==================================================================
+ Hits                                 2995     3037      +42     
- Misses                                581      584       +3     
- Partials                              245      248       +3     
Impacted Files Coverage Δ
...311/Endpoint/Integration/UK/CentralBedfordshire.pm 92.42% <90.56%> (-7.58%) ⬇️
perllib/Open311/Endpoint/Integration/Symology.pm 83.76% <0.00%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05bc833...4be610f. Read the comment docs.

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, would be good to have all the configuration parameters documented/exampled.

@davea davea force-pushed the central-beds-symology-api-getrequests branch from eb1dca2 to 4be610f Compare December 1, 2020 14:13
@davea davea merged commit 4be610f into central-beds-symology-reviewed Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants