Add a script to fix inconsistent references to people from SayIt speakers #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhl
force-pushed
the
1597-fix-committee-appearances
branch
from
3ab8da2
to
57bf083
Compare
|
It's been tested on the copy of the data, and it's coded quite safely so shouldn't delete anything that might still be in use, so 👍 |
…kers We have changed the form of IDs in the South African PopIt instance several times, but without removing the entries corresponding to old PopIt IDs from the popit-django popit_person table. This meant that the name resolution on importing new committee proceedings could associate the speeches with various SayIt speakers corresponding to different entries in that table. This commit introduces a script to hopefully clean up that mess; it tries to remove any row with an deprecated format ID from the popit_person table, safely removing any SayIt Speaker or EntityName associated with that row. It also removes any rows from this table that can't be associated with any Pombola core Person any more, so long as they are not referenced any more. This should fix #1597 and hopefully #1601. The underlying issue (that Pombola ZA stores the identity of people in five different places) is being addressed by #1594.
mhl
force-pushed
the
1597-fix-committee-appearances
branch
from
57bf083
to
82bb11c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have changed the form of IDs in the South African PopIt instance
several times, but without removing the entries corresponding to old
PopIt IDs from the popit-django popit_person table. This meant that the
name resolution on importing new committee proceedings could associate
the speeches with various SayIt speakers corresponding to different
entries in that table.
This pull request introduces a script to hopefully clean up that mess; it
tries to remove any row with an deprecated format ID from the
popit_person table, safely removing any SayIt Speaker associated with
that row.
This should fix #1597 and hopefully #1601.
The underlying issue (that Pombola ZA stores the identity of people in
five different places) is being addressed by #1594.