Version 1.4 #504
Merged
Version 1.4 #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A couple of minor comments (and I should say that I haven't tried the code, just read through the PR) but this looks good to me 👍 |
dracos
force-pushed
the
version-1.4
branch
2 times, most recently
from
352b4fd
to
28961ca
Compare
|
@mhl There have been quite a few changes since the review (though nothing major, pulling in a few changes from the 1.9 branch that could be here mostly), so probably worth another quick glance if possible before I merge? :) |
|
Sorry, @dracos, I just noticed this - I'll look again tomorrow morning |
|
This looks good to me. If all goes well I'll be planning to do the Pombola Django 1.8 upgrade on Monday morning, so it'll be great to have this released before then. (I think that doing that upgrade will probably provide better assurance than me reading through the patches :)) |
Remove things now in core: * South * blocktrans trimmed * qmethod Remove workarounds for older Django versions: * Patch for get_queryset (1.6+) * Lack of foreign key following in get_or_create (1.6+) * Tests involving overriding MEDIA_URL (1.5+) * Caching speech template to have date change correctly (1.7+) Upgrade third-party apps to 1.8-supported versions: * Select2 * Haystack (and allow greater range of ElasticSearch versions). * nose * django-sluggable * django-subdomain-instances * django-popolo Fix new issues, upcoming deprecations, or hints: * Move GenericRelation import * Call super() in setUpClass * form_class is optional in get_form() * Remove null=True from ManyToMany field. * Global TEMPLATE_CONTEXT_PROCESSORS might be a list * Removal of django.utils.unittest * Remove unneeded url future import. * Deal with rename of form.util to form.utils. * Specify URL includes as callables. * Drop use of patterns() in urls.py.
This includes the verbose name changes to instance fields from the upgrade to django-subdomain-instances, and the dropping of default speaker ordering from 9d1a53b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was waiting for updated mysociety-django-popolo to be put on PyPI; I've now done this, version 0.0.5, so this branch should be okay now, for Django 1.8 support.