[#751] Fix apostrophe tags in help pages #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor change to multiple files, correcting the apostrophe tag from ' to ’
A minor correction to the apostrophe tag we use in multiple paragraphs. There is no other change to the substance of the Privacy Notice.
Minor corrections to the apostrophe used within multiple files
A minor change to correct the apostrophe tags used within the House Rules to provide consistency. There are no other changes.
mdeuk
changed the title
garethrees
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #751
What does this do?
This PR swaps out the apostrophe character that we've used in some help pages.
Why was this needed?
We've inconsistently used both
'and’within help documents, which creates a slight semantic issue and makes the code slightly clunky to work with.Implementation notes
This is a straight swap of characters in almost all cases - taking care not to mess with legitimate instances of the
'character within links.Screenshots
N/A
Notes to reviewer
I have intentionally skipped unhappy.html.erb since changes to this file will likely be committed elsewhere.
This replaces a previous PR which contained a glitch that had been pushed in error.