Skip to content

Commit

Permalink
Fix for Bug#94414 (29384853), Connector/J RPM package have version nu…
Browse files Browse the repository at this point in the history
…mber in path.

Background:
 According to RPM package policy[1], jar files should not have version
 in filename. A unversioned filename makes it more simple to upgrade
 the package without doing other changes.

Fix:
 Use %{name} RPM macro to name the jar file, giving wanted filename in
 all cases. Also fix build.xml to accept more generic output from
  java -version

[1]: https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/
  • Loading branch information
trosten authored and fjssilva committed Feb 27, 2019
1 parent f5d24e3 commit 1fecc2b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 2 additions & 0 deletions CHANGES
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@

Version 8.0.16

- Fix for Bug#94414 (29384853), Connector/J RPM package have version number in path.

- Fix for Bug#27786499, REDUNDANT FILES IN DEBIAN PACKAGE FOR DEBIAN9(COMMUNITY PACKAGE) FOR CJAVA.

- WL#12246, DevAPI: Prepared statement support.
Expand Down
2 changes: 1 addition & 1 deletion build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ See also com.mysql.cj.conf.PropertyDefinitions.SYSP_* variables for other test o
<not>
<and>
<equals arg1="${com.mysql.cj.build.jdk.exitStatus}" arg2="0" />
<contains string="${com.mysql.cj.build.jdk.version}" substring="java version &quot;1.8" casesensitive="true" />
<contains string="${com.mysql.cj.build.jdk.version}" substring="version &quot;1.8" casesensitive="true" />
</and>
</not>
</condition>
Expand Down
6 changes: 3 additions & 3 deletions src/build/misc/rpm.spec.in
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2017, 2018, Oracle and/or its affiliates. All rights reserved.
# Copyright (c) 2017, 2019, Oracle and/or its affiliates. All rights reserved.
#
# This program is free software; you can redistribute it and/or modify it under
# the terms of the GNU General Public License, version 2.0, as published by the
Expand Down Expand Up @@ -166,7 +166,7 @@ cp %{with_docs}/en/txt/connector-j.txt package-content/docs/

%install
install -d -m 0755 %{buildroot}%{_javadir}
install -p -m 0644 package-content/@MYSQL_CJ_FULL_PROD_NAME@.jar %{buildroot}%{_javadir}/@MYSQL_CJ_FULL_PROD_NAME@.jar
install -p -m 0644 package-content/@MYSQL_CJ_FULL_PROD_NAME@.jar %{buildroot}%{_javadir}/%{name}.jar

%clean
rm -rf %{buildroot}
Expand All @@ -187,7 +187,7 @@ rm -rf %{buildroot}
%doc package-content/docs/mvl.css
%endif

%{_javadir}/@MYSQL_CJ_FULL_PROD_NAME@.jar
%{_javadir}/%{name}.jar

%changelog
* Mon Nov 27 2017 MySQL Release Engineering <mysql-build@oss.oracle.com> - 8.0.9-1
Expand Down

0 comments on commit 1fecc2b

Please sign in to comment.