-
Notifications
You must be signed in to change notification settings - Fork 309
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Drop map locking from policy repository
- Loading branch information
Showing
2 changed files
with
248 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,204 @@ | ||
| /* | ||
| * Copyright (C) 2020 The "MysteriumNetwork/node" Authors. | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
| * the Free Software Foundation, either version 3 of the License, or | ||
| * (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| package policy | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "net/http" | ||
| "net/http/httptest" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/mysteriumnetwork/node/market" | ||
| "github.com/mysteriumnetwork/node/requests" | ||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| var ( | ||
| policyOneRules = market.AccessPolicyRuleSet{ | ||
| ID: "1", | ||
| Title: "One", | ||
| Allow: []market.AccessRule{ | ||
| {Type: market.AccessPolicyTypeIdentity, Value: "0x1"}, | ||
| }, | ||
| } | ||
| policyTwoRules = market.AccessPolicyRuleSet{ | ||
| ID: "2", | ||
| Title: "Two", | ||
| Allow: []market.AccessRule{ | ||
| {Type: market.AccessPolicyTypeDNSHostname, Value: "ipinfo.io"}, | ||
| }, | ||
| } | ||
| policyTreeRules = market.AccessPolicyRuleSet{ | ||
| ID: "3", | ||
| Title: "Three", | ||
| Allow: []market.AccessRule{ | ||
| {Type: market.AccessPolicyTypeDNSZone, Value: "ipinfo.io"}, | ||
| }, | ||
| } | ||
| ) | ||
|
|
||
| func Test_PolicyRepository_Policy(t *testing.T) { | ||
| repo := &PolicyRepository{policyURL: "http://policy.localhost"} | ||
| assert.Equal( | ||
| t, | ||
| market.AccessPolicy{ID: "1", Source: "http://policy.localhost/1"}, | ||
| repo.Policy("1"), | ||
| ) | ||
|
|
||
| repo = &PolicyRepository{policyURL: "http://policy.localhost/"} | ||
| assert.Equal( | ||
| t, | ||
| market.AccessPolicy{ID: "2", Source: "http://policy.localhost/2"}, | ||
| repo.Policy("2"), | ||
| ) | ||
| } | ||
|
|
||
| func Test_PolicyRepository_Policies(t *testing.T) { | ||
| repo := &PolicyRepository{policyURL: "http://policy.localhost"} | ||
| assert.Equal( | ||
| t, | ||
| []market.AccessPolicy{ | ||
| {ID: "1", Source: "http://policy.localhost/1"}, | ||
| }, | ||
| repo.Policies([]string{"1"}), | ||
| ) | ||
|
|
||
| repo = &PolicyRepository{policyURL: "http://policy.localhost/"} | ||
| assert.Equal( | ||
| t, | ||
| []market.AccessPolicy{ | ||
| {ID: "2", Source: "http://policy.localhost/2"}, | ||
| {ID: "3", Source: "http://policy.localhost/3"}, | ||
| }, | ||
| repo.Policies([]string{"2", "3"}), | ||
| ) | ||
| } | ||
|
|
||
| func Test_PolicyRepository_RulesForPolicy(t *testing.T) { | ||
| repo := createEmptyRepo("http://policy.localhost") | ||
| policyRules, err := repo.RulesForPolicy(repo.Policy("1")) | ||
| assert.EqualError(t, err, "unknown policy: {1 http://policy.localhost/1}") | ||
| assert.Equal(t, market.AccessPolicyRuleSet{}, policyRules) | ||
|
|
||
| repo = createFullRepo("http://policy.localhost") | ||
| policyRules, err = repo.RulesForPolicy(repo.Policy("1")) | ||
| assert.NoError(t, err) | ||
| assert.Equal(t, policyOneRules, policyRules) | ||
| } | ||
|
|
||
| func Test_PolicyRepository_RulesForPolicies(t *testing.T) { | ||
| repo := createEmptyRepo("http://policy.localhost") | ||
| policiesRules, err := repo.RulesForPolicies([]market.AccessPolicy{ | ||
| repo.Policy("1"), | ||
| repo.Policy("3"), | ||
| }) | ||
| assert.EqualError(t, err, "unknown policy: {1 http://policy.localhost/1}") | ||
| assert.Equal(t, []market.AccessPolicyRuleSet{}, policiesRules) | ||
|
|
||
| repo = createFullRepo("http://policy.localhost") | ||
| policiesRules, err = repo.RulesForPolicies([]market.AccessPolicy{ | ||
| repo.Policy("1"), | ||
| repo.Policy("3"), | ||
| }) | ||
| assert.NoError(t, err) | ||
| assert.Equal(t, []market.AccessPolicyRuleSet{policyOneRules, policyTreeRules}, policiesRules) | ||
| } | ||
|
|
||
| func Test_PolicyRepository_AddPolicies_WhenEndpointFails(t *testing.T) { | ||
| server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| w.WriteHeader(http.StatusInternalServerError) | ||
| })) | ||
| defer server.Close() | ||
|
|
||
| repo := createEmptyRepo(server.URL) | ||
| err := repo.AddPolicies([]market.AccessPolicy{ | ||
| repo.Policy("1"), | ||
| repo.Policy("3"), | ||
| }) | ||
| assert.EqualError( | ||
| t, | ||
| err, | ||
| fmt.Sprintf("initial fetch failed: failed fetch policy rule {1 %s/1}: server response invalid: 500 Internal Server Error (%s/1)", server.URL, server.URL), | ||
| ) | ||
| assert.Equal(t, []policyMetadata{}, repo.policyList) | ||
| } | ||
|
|
||
| func Test_PolicyRepository_AddPolicies_WhenEndpointSucceeds(t *testing.T) { | ||
| server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| if r.URL.Path == "/1" { | ||
| w.WriteHeader(http.StatusOK) | ||
| _, _ = w.Write([]byte(`{ | ||
| "id": "1", | ||
| "title": "One", | ||
| "description": "", | ||
| "allow": [ | ||
| {"type": "identity", "value": "0x1"} | ||
| ] | ||
| }`)) | ||
| } else if r.URL.Path == "/3" { | ||
| w.WriteHeader(http.StatusOK) | ||
| _, _ = w.Write([]byte(`{ | ||
| "id": "3", | ||
| "title": "Three", | ||
| "description": "", | ||
| "allow": [ | ||
| {"type": "dns_zone", "value": "ipinfo.io"} | ||
| ] | ||
| }`)) | ||
| } else { | ||
| w.WriteHeader(http.StatusNotFound) | ||
| } | ||
| })) | ||
| defer server.Close() | ||
|
|
||
| repo := createEmptyRepo(server.URL) | ||
| err := repo.AddPolicies([]market.AccessPolicy{ | ||
| repo.Policy("1"), | ||
| repo.Policy("3"), | ||
| }) | ||
| assert.NoError(t, err) | ||
| assert.Equal( | ||
| t, | ||
| []policyMetadata{ | ||
| {policy: repo.Policy("1"), rules: policyOneRules}, | ||
| {policy: repo.Policy("3"), rules: policyTreeRules}, | ||
| }, | ||
| repo.policyList, | ||
| ) | ||
| } | ||
|
|
||
| func createEmptyRepo(policyURL string) *PolicyRepository { | ||
| return &PolicyRepository{ | ||
| client: requests.NewHTTPClient("0.0.0.0", time.Second), | ||
| policyURL: policyURL + "/", | ||
| policyList: []policyMetadata{}, | ||
| } | ||
| } | ||
|
|
||
| func createFullRepo(policyURL string) *PolicyRepository { | ||
| repo := &PolicyRepository{ | ||
| client: requests.NewHTTPClient("0.0.0.0", time.Second), | ||
| policyURL: policyURL + "/", | ||
| policyList: make([]policyMetadata, 3), | ||
| } | ||
| repo.policyList[0] = policyMetadata{policy: repo.Policy("1"), rules: policyOneRules} | ||
| repo.policyList[1] = policyMetadata{policy: repo.Policy("2"), rules: policyTwoRules} | ||
| repo.policyList[2] = policyMetadata{policy: repo.Policy("3"), rules: policyTreeRules} | ||
| return repo | ||
| } |