Skip to content

Commit

Permalink
Improve documentation
Browse files Browse the repository at this point in the history
  • Loading branch information
Waldz committed Jun 7, 2018
1 parent 76f018b commit e3e1829
Show file tree
Hide file tree
Showing 7 changed files with 20 additions and 18 deletions.
1 change: 1 addition & 0 deletions .travis.yml
Expand Up @@ -43,6 +43,7 @@ script:
bin/travis_scripts/check_docker.sh;
bin/travis_scripts/check_docker_compose.sh;

# This checks requires development dependency
bin/builder_run bin/check_lint

# Run e2e tests on Pull Requests only
Expand Down
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Expand Up @@ -129,19 +129,19 @@ this PR will be merged into main branch.

Before creating PR be sure to:

* **Step 1.** Ensure sure that **your** code quality is passing
* **Step 1.** Ensure that **your** code quality is passing

```bash
bin/check
```

* **Step 2.** Ensure that all unit tests passes
* **Step 2.** Ensure that all unit tests pass

```bash
bin/test
```

* **Step 3.** Ensure that all end-to-end tests passes
* **Step 3.** Ensure that all end-to-end tests pass

```bash
bin/test_e2e
Expand Down
2 changes: 1 addition & 1 deletion bin/builder_docker/Dockerfile
Expand Up @@ -7,7 +7,7 @@ RUN apt-get update \
&& gem install ffi -v 1.9.18 \
&& gem install fpm -v 1.9.3

# Install development tools
# Install development dependencies
RUN go get \
github.com/debber/debber-v0.3/cmd/debber \
github.com/golang/lint/golint
Expand Down
2 changes: 1 addition & 1 deletion bin/check
@@ -1,6 +1,6 @@
#!/bin/bash

# Runs tests and code quality checks
# Runs code quality checks
#
# Usage:
#> bin/check
Expand Down
2 changes: 1 addition & 1 deletion bin/check_fmt
Expand Up @@ -3,7 +3,7 @@
# Checks if all project files are formatted using go fmt
#
# Usage:
#> bin/fmt
#> bin/check_fmt

source bin/helpers/output.sh

Expand Down
13 changes: 7 additions & 6 deletions bin/check_lint
Expand Up @@ -3,17 +3,18 @@
# Run code Linter for project packages
#
# Usage:
#> bin/lint [packages ...]
#> bin/check_lint [packages ...]
#
# Examples:
#> bin/lint
#> bin/lint .
#> bin/lint ./...
#> bin/lint ./communication
#> bin/lint ./communication/...
#> bin/check_lint
#> bin/check_lint .
#> bin/check_lint ./...
#> bin/check_lint ./communication
#> bin/check_lint ./communication/...

ARGUMENTS=$@
if [ -z "$ARGUMENTS" ]; then
# By default, disable checks packages that are declared as not-cleared
ARGUMENTS=`
go list ./... \
| grep -v "github.com/mysterium/node/cmd" \
Expand Down
12 changes: 6 additions & 6 deletions bin/check_vet
Expand Up @@ -3,14 +3,14 @@
# Run Go vet command for project packages
#
# Usage:
#> bin/vet [packages ...]
#> bin/check_vet [packages ...]
#
# Examples:
#> bin/vet
#> bin/vet .
#> bin/vet ./...
#> bin/vet ./communication
#> bin/vet ./communication/...
#> bin/check_vet
#> bin/check_vet .
#> bin/check_vet ./...
#> bin/check_vet ./communication
#> bin/check_vet ./communication/...

ARGUMENTS=$@
if [ -z "$ARGUMENTS" ]; then
Expand Down

0 comments on commit e3e1829

Please sign in to comment.