Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: add Makefile to install glide, build server and client #105

Merged
merged 2 commits into from Jan 21, 2018
Merged

WIP: add Makefile to install glide, build server and client #105

merged 2 commits into from Jan 21, 2018

Conversation

zyfdegh
Copy link
Contributor

@zyfdegh zyfdegh commented Jan 21, 2018 •
edited by Waldz

Described in Issue #23
Makefile supports:

  • install glide
  • build server binary
  • build client binary
  • build server Docker image
  • build client Docker image

Please take time to review, thank you.

Waldz
Waldz reviewed Jan 21, 2018
View reviewed changes
Makefile Outdated
glide install

server:
go build -o $(BUILD_OUTPUT)/server cmd/mysterium_server/mysterium_server.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be using bin/server_build helper, which includes build variables from .env

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK! thank you

@Waldz Waldz merged commit 193882b into mysteriumnetwork:master Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Waldz Waldz Waldz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zyfdegh @Waldz