Register to my.mysterium.network #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignasbernotas
changed the title
vkuznecovas
suggested changes
Sep 12, 2019
zolia
reviewed
Sep 13, 2019
zolia
suggested changes
Sep 13, 2019
soffokl
reviewed
Sep 15, 2019
| client.RegisterNode(*info) | ||
| }) | ||
| if err != nil { | ||
| log.Error("Failed to get register to mmn event", err.Error()) |
There was a problem hiding this comment.
Suggested change
| log.Error("Failed to get register to mmn event", err.Error()) | |
| log.Error("Failed to get register to mmn event", err) |
There was a problem hiding this comment.
My suggestion is removing explicit converting to string, it enough to just pass err here.
ignasbernotas
force-pushed
the
feature/node-linking-to-account
branch
from
2fcc365
to
65f2260
Compare
ignasbernotas
changed the title
ignasbernotas
force-pushed
the
feature/node-linking-to-account
branch
from
babdaa7
to
6890b55
Compare
soffokl
reviewed
Sep 18, 2019
tadaskay
requested changes
Sep 18, 2019
tadaskay
approved these changes
Sep 18, 2019
zolia
suggested changes
Sep 19, 2019
ignasbernotas
force-pushed
the
feature/node-linking-to-account
branch
from
8da70f1
to
b68bba7
Compare
vkuznecovas
approved these changes
Sep 20, 2019
zolia
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.