Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send etag while pulling proposals #1321

Merged
merged 6 commits into from
Oct 7, 2019
Merged

Send etag while pulling proposals #1321

merged 6 commits into from
Oct 7, 2019

Conversation

anjmao
Copy link
Contributor

@anjmao anjmao commented Oct 3, 2019 •
edited

Fixes #1319

soffokl
soffokl reviewed Oct 4, 2019
View reviewed changes
market/mysterium/mysterium_api.go Outdated Show resolved Hide resolved
market/mysterium/mysterium_api.go Outdated Show resolved Hide resolved
vkuznecovas
vkuznecovas suggested changes Oct 4, 2019
View reviewed changes
market/mysterium/mysterium_api.go Outdated Show resolved Hide resolved
@anjmao anjmao force-pushed the improvement/cache-proposals-fetch branch from 6263307 to 424eb9f Compare October 4, 2019 11:41
@zolia
Copy link
Contributor

zolia commented Oct 7, 2019

Do I understand correctly that StatusNotModified would be returned from our Discovery and that it has to be implemented there still? Do we have a task for it? This etag will be some sort of hash?

@anjmao
Copy link
Contributor Author

anjmao commented Oct 7, 2019

@zolia I implemented changes in discovery api already https://github.com/mysteriumnetwork/api/blob/master/api/proposals.py#L151

@zolia
Copy link
Contributor

zolia commented Oct 7, 2019

Cool, now I see. Thanx.

zolia
zolia approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@zolia zolia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API should be deployed first or will it be backwards compatible?

@anjmao anjmao force-pushed the improvement/cache-proposals-fetch branch from f606bcd to 3e55f6c Compare October 7, 2019 11:17
@anjmao
Copy link
Contributor Author

anjmao commented Oct 7, 2019

@zolia It will be backwards compatible.

@anjmao anjmao merged commit cbe0ffc into master Oct 7, 2019
@anjmao anjmao deleted the improvement/cache-proposals-fetch branch October 7, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soffokl soffokl soffokl left review comments

@ignasbernotas ignasbernotas ignasbernotas approved these changes

@tadaskay tadaskay tadaskay approved these changes

@zolia zolia zolia approved these changes

@vkuznecovas vkuznecovas vkuznecovas approved these changes

@tadovas tadovas Awaiting requested review from tadovas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cache discovery API proposals http response
6 participants
@anjmao @zolia @ignasbernotas @tadaskay @soffokl @vkuznecovas