Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on proposal synchronisation from Broker discovery #1479

Merged
merged 8 commits into from Jan 8, 2020
Merged

Turn on proposal synchronisation from Broker discovery #1479

merged 8 commits into from Jan 8, 2020

Conversation

Waldz
Copy link
Member

@Waldz Waldz commented Jan 2, 2020

Proposals are started to be synchronised from 2 sources - api+broker.

@Waldz Waldz requested a review from tadovas as a code owner January 2, 2020 15:15
@Waldz Waldz force-pushed the feature/proposals-to-broker branch 5 times, most recently from b0c75bf to ea3da69 Compare January 2, 2020 16:31
anjmao
anjmao reviewed Jan 3, 2020
View reviewed changes
core/discovery/broker/messaging_ping.go Outdated Show resolved Hide resolved
core/discovery/broker/subscriber.go Outdated Show resolved Hide resolved
cmd/di.go Outdated Show resolved Hide resolved
core/discovery/broker/subscriber.go Outdated Show resolved Hide resolved
core/discovery/broker/subscriber.go Outdated Show resolved Hide resolved
core/discovery/broker/subscriber.go Outdated Show resolved Hide resolved
core/discovery/broker/subscriber.go Outdated Show resolved Hide resolved
core/discovery/broker/subscriber.go Outdated Show resolved Hide resolved
anjmao
anjmao reviewed Jan 3, 2020
View reviewed changes
core/discovery/broker/subscriber_test.go Outdated Show resolved Hide resolved
core/discovery/storage.go Outdated Show resolved Hide resolved
core/discovery/storage.go Outdated Show resolved Hide resolved
core/discovery/storage_test.go Outdated Show resolved Hide resolved
zolia
zolia approved these changes Jan 6, 2020
View reviewed changes
core/discovery/broker/messaging_register.go Outdated Show resolved Hide resolved
core/discovery/broker/subscriber_test.go Outdated Show resolved Hide resolved
core/discovery/storage.go Outdated Show resolved Hide resolved
core/discovery/storage.go Outdated Show resolved Hide resolved
core/discovery/storage.go Outdated Show resolved Hide resolved
core/discovery/storage_test.go Outdated Show resolved Hide resolved
@zolia
Copy link
Contributor

zolia commented Jan 6, 2020

Looks like we might need it soon :) our discovery having load issues again :)

@Waldz Waldz force-pushed the feature/proposals-to-broker branch from 5ec04c0 to d51b5c2 Compare January 7, 2020 00:42
@Waldz Waldz requested a review from anjmao January 7, 2020 00:43
soffokl
soffokl reviewed Jan 7, 2020
View reviewed changes
core/discovery/broker/subscriber.go Outdated Show resolved Hide resolved
core/discovery/broker/subscriber.go Outdated Show resolved Hide resolved
core/discovery/broker/subscriber.go Outdated Show resolved Hide resolved
core/discovery/broker/subscriber.go Outdated Show resolved Hide resolved
core/discovery/broker/subscriber_test.go Outdated Show resolved Hide resolved
core/discovery/storage_test.go Show resolved Hide resolved
@Waldz Waldz force-pushed the feature/proposals-to-broker branch 2 times, most recently from 3a8bbc1 to 3fb9c09 Compare January 7, 2020 13:28
@Waldz Waldz requested a review from soffokl January 8, 2020 16:03
@Waldz Waldz force-pushed the feature/proposals-to-broker branch from 8f767e6 to 4ef131b Compare January 8, 2020 16:19
@codecov-io
Copy link

Codecov Report

Merging #1479 into master will increase coverage by 0.56%.
The diff coverage is 89.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1479      +/-   ##
==========================================
+ Coverage   47.06%   47.63%   +0.56%     
==========================================
  Files         283      282       -1     
  Lines       10648    10725      +77     
==========================================
+ Hits         5012     5109      +97     
+ Misses       5249     5227      -22     
- Partials      387      389       +2
Impacted Files Coverage Δ
session/create_consumer.go 68.08% <ø> (ø) ⬆️
core/promise/balance_consumer.go 0% <ø> (ø) ⬆️
mobile/mysterium/entrypoint.go 0% <0%> (ø) ⬆️
core/discovery/api/registry.go 0% <0%> (ø) ⬆️
core/discovery/broker/messaging_ping.go 100% <100%> (ø)
mobile/mysterium/proposals_manager.go 74.25% <100%> (+2.68%) ⬆️
core/discovery/storage.go 93.87% <100%> (+57.51%) ⬆️
core/discovery/broker/messaging_unregister.go 100% <100%> (ø) ⬆️
core/discovery/broker/registry.go 100% <100%> (ø) ⬆️
core/discovery/broker/messaging_register.go 100% <100%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1a993a...4ef131b. Read the comment docs.

@Waldz Waldz merged commit b63e2fb into master Jan 8, 2020
@Waldz Waldz deleted the feature/proposals-to-broker branch January 8, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjmao anjmao anjmao approved these changes

@zolia zolia zolia approved these changes

@chompomonim chompomonim Awaiting requested review from chompomonim

@ignasbernotas ignasbernotas Awaiting requested review from ignasbernotas

@tadaskay tadaskay Awaiting requested review from tadaskay tadaskay is a code owner

@vkuznecovas vkuznecovas Awaiting requested review from vkuznecovas

@tadovas tadovas Awaiting requested review from tadovas

@soffokl soffokl Awaiting requested review from soffokl soffokl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Waldz @zolia @codecov-io @anjmao @soffokl