Improve node disconnect time #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadaskay
requested review from
soffokl,
tadovas,
vkuznecovas and
zolia
as code owners
vkuznecovas
suggested changes
Jan 8, 2020
tadaskay
force-pushed
the
1484-node-slow-disconnect
branch
from
def739a
to
e7227ae
Compare
vkuznecovas
approved these changes
Jan 8, 2020
tadaskay
force-pushed
the
1484-node-slow-disconnect
branch
from
e7227ae
to
4574a4e
Compare
anjmao
reviewed
Jan 8, 2020
anjmao
approved these changes
Jan 8, 2020
zolia
approved these changes
Jan 8, 2020
soffokl
approved these changes
Jan 9, 2020
This ensures that the broker is reachable. If provider doesn't provide network connectivity, all calls to the broker will fail, resulting in timeouts. There's a greater chance that it will work after the disconnect, because the initial connection dialog was established via broker using consumer's original network interface.
tadaskay
force-pushed
the
1484-node-slow-disconnect
branch
from
4574a4e
to
e9f65c7
Compare
Waldz
approved these changes
Jan 9, 2020
tadaskay
force-pushed
the
1484-node-slow-disconnect
branch
from
e9f65c7
to
428e3ce
Compare
tadaskay
force-pushed
the
1484-node-slow-disconnect
branch
from
428e3ce
to
c3053e3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1491 +/- ##
==========================================
+ Coverage 47.63% 47.81% +0.18%
==========================================
Files 282 284 +2
Lines 10725 10789 +64
==========================================
+ Hits 5109 5159 +50
- Misses 5226 5240 +14
Partials 390 390
Continue to review full report at Codecov.
|
anjmao
approved these changes
Jan 9, 2020
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestBrokerConnector(t *testing.T) { |
There was a problem hiding this comment.
- Would be better to have isolated unit test which doesn't start real nats server. Calling connector.Connect could assert that mock conn Open was called and is added to registry map. Also it could assert that after closing conn it's removed from registry.
- ReconnectAll is not tested. Again if mock conn is used it's enough to test if Check method is called.
- Tests would be much faster too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore connections to broker after connect/disconnect.
Fixes: #1484