switch to locks from atomics #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes panics on some systems while trying to atomically load a uint ``` panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x4 pc=0x12488] goroutine 343 [running]: github.com/mysteriumnetwork/node/session/pingpong.(*InvoiceTracker).getNotReceivedExchangeMessageCount(...) /Users/anjmao/go/src/github.com/mysteriumnetwork/node/session/pingpong/invoice_tracker.go:384 github.com/mysteriumnetwork/node/session/pingpong.(*InvoiceTracker).sendInvoice(0x29246e0, 0x28bfed4, 0x4) /Users/anjmao/go/src/github.com/mysteriumnetwork/node/session/pingpong/invoice_tracker.go:394 +0x28 github.com/mysteriumnetwork/node/session/pingpong.(*InvoiceTracker).Start(0x29246e0, 0x229c76c, 0x4523b0) /Users/anjmao/go/src/github.com/mysteriumnetwork/node/session/pingpong/invoice_tracker.go:356 +0x458 github.com/mysteriumnetwork/node/session.(*Manager).Create.func2(0x14807f8, 0x29246e0, 0x270e700, 0x1328f020, 0x2a, 0x132638b0) /Users/anjmao/go/src/github.com/mysteriumnetwork/node/session/manager.go:183 +0x24 created by github.com/mysteriumnetwork/node/session.(*Manager).Create /Users/anjmao/go/src/github.com/mysteriumnetwork/node/session/manager.go:182 +0x358 ```
vkuznecovas
force-pushed
the
remove-atomics
branch
from
ca70b95
to
a601203
Compare
zolia
approved these changes
Jan 13, 2020
anjmao
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes panics on some systems while trying to atomically load a uint